Implemented alternative experiment tracking functionality #102
Conversation
…andrainst/coral into feature/experiment_tracking
|
Im on the errors now |
There was a problem hiding this comment.
Really like the idea, and great execution! 😃
I've got a couple of small comments, and there's a style check that is currently failing. You can install pre-commit hooks with make install-pre-commit, which will ensure that your style checks pass before committing. You can also run make clean to do it manually.
To make the code base slightly more lean, I would suggest that we keep the directory structure flat, with a single module, experiment_tracking.py, which then contains both the load_extracking_setup function as well as the MLFlowSetup and WandbSetup classes, since they're all quite small. The abstract ExtrackingSetup can be moved to the data_models module, as that's where all the other abstract classes are.
|
@saattrupdan Ready for final review |
No description provided.