Add todos for auto rollback.

Change minReady to 0
alex4108 · Sep 20, 2022 · 0944e68 · 0944e68
1 parent fb2e32f
commit 0944e68
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -69,6 +69,8 @@ jobs:
           manifests: |
             kube-manifest.yml
           images: "alex4108/approova:${{needs.build.outputs.tag}}"
+      # TODO if deploy failed, `kubectl rollout undo Deployment/approovalive`
+      # TODO if deploy failed, don't create release.
       - name: Create a GitHub release
         uses: ncipollo/release-action@v1
         with:

diff --git a/kube-manifest.yml b/kube-manifest.yml
@@ -36,7 +36,6 @@ metadata:
   name: approova-live
 spec:
   replicas: 1
-  minReadySeconds: 60
   selector:
     matchLabels:
       name: approova-live