Automatic Updates according to Errorprone Maven plugin run

.gitignore

@@ -17,6 +17,9 @@ build/
 # Logs
 *.log
 
+# Errorprone issues json
+errorprone_issues.json
+
 # Temporary files
 *.tmp
 *.swp

src/main/java/com/example/modfac/controller/EmployeeController.java

@@ -23,8 +23,8 @@
 @RequiredArgsConstructor
 public class EmployeeController {
     private static final org.slf4j.Logger LOG = org.slf4j.LoggerFactory.getLogger(EmployeeController.class);
-    private static final org.slf4j.Logger APPLICATION_LOGGER = org.slf4j.LoggerFactory.getLogger(EmployeeController.class);
     private final DataService dataService;
+
     @PostMapping
     public ResponseEntity<Employee> onboardEmployee(
             @Valid @RequestBody OnboardEmployeeDTO dto,

src/main/java/com/example/modfac/security/CustomUserDetailsService.java

@@ -15,8 +15,6 @@
 @RequiredArgsConstructor
 public class CustomUserDetailsService implements UserDetailsService {
     private static final org.slf4j.Logger LOG = org.slf4j.LoggerFactory.getLogger(CustomUserDetailsService.class);
-    private static final org.slf4j.Logger LOGGER = org.slf4j.LoggerFactory.getLogger(CustomUserDetailsService.class);
-
     private final UserRepository userRepository;
 
     @Override
@@ -32,4 +30,4 @@ public UserDetails loadUserByUsername(String username) throws UsernameNotFoundEx
                 Collections.singletonList(new SimpleGrantedAuthority("ROLE_" + user.getRole()))
         );
     }
-}
+}

src/main/java/com/example/modfac/security/JwtAuthenticationFilter.java

@@ -20,6 +20,7 @@
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Locale;
 
 @Component
 @RequiredArgsConstructor
@@ -48,7 +49,7 @@ protected void doFilterInternal(
 
                 List<GrantedAuthority> authorities = new ArrayList<>();
                 if (StringUtils.hasText(role)) {
-                    authorities.add(new SimpleGrantedAuthority("ROLE_" + role.toUpperCase()));
+                    authorities.add(new SimpleGrantedAuthority(String.format("ROLE_%s", role.toUpperCase(Locale.ROOT))));
                 }
 
                 UserDetails userDetails = userDetailsService.loadUserByUsername(username);
@@ -59,8 +60,6 @@ protected void doFilterInternal(
                 authentication.setDetails(new WebAuthenticationDetailsSource().buildDetails(request));
                 SecurityContextHolder.getContext().setAuthentication(authentication);
             } else {
-                // If we reach here, it means the JWT token is invalid or missing
-                // So we set the WWW-Authenticate header and throw a 401 response
                 response.setHeader("WWW-Authenticate", "Bearer");
                 response.setStatus(HttpServletResponse.SC_UNAUTHORIZED);
                 return;
@@ -99,4 +98,4 @@ private String getJwtFromRequest(HttpServletRequest request) {
         LOGGER.debug("getJwtFromRequest method finished");
         return null;
     }
-}
+}

src/main/java/com/example/modfac/security/JwtTokenProvider.java

@@ -10,6 +10,7 @@
 
 import javax.crypto.SecretKey;
 import java.nio.charset.StandardCharsets;
+import java.time.Instant;
 import java.util.Date;
 import java.util.HashMap;
 import java.util.Map;
@@ -40,13 +41,13 @@ public String createToken(String username, String role) {
         claims.put("sub", username); // subject claim
         claims.put("role", role);    // custom role claim
 
-        Date now = new Date();
-        Date validity = new Date(now.getTime() + jwtExpiration);
+        Instant now = Instant.now();
+        Instant validity = now.plusMillis(jwtExpiration);
 
         String token = Jwts.builder()
                 .claims(claims)
-                .issuedAt(now)
-                .expiration(validity)
+                .issuedAt(Date.from(now))
+                .expiration(Date.from(validity))
                 .signWith(key, Jwts.SIG.HS256)
                 .compact();
 
@@ -70,7 +71,9 @@ public boolean validateToken(String token) {
                     .build()
                     .parseSignedClaims(token);
 
-            boolean isValid = !claims.getPayload().getExpiration().before(new Date());
+            Instant expiration = claims.getPayload().getExpiration().toInstant();
+            boolean isValid = !expiration.isBefore(Instant.now());
+
             LOG.debug("validateToken method finished");
             return isValid;
         } catch (JwtException | IllegalArgumentException e) {