Skip to content

TXB creation for capybot transactions - #4

Open
comradekoval wants to merge 29 commits into
mainfrom
feat/mcga
Open

TXB creation for capybot transactions#4
comradekoval wants to merge 29 commits into
mainfrom
feat/mcga

Conversation

@comradekoval

Copy link
Copy Markdown
Contributor

Also requires you to change some of Cetus' code - not a good practice in any sense.

rockbmb and others added 29 commits March 16, 2024 18:51
Also added a couple of small fixes.
@comradekoval
comradekoval deleted the feat/mcga branch April 11, 2024 15:31
@comradekoval
comradekoval restored the feat/mcga branch April 11, 2024 15:34
@comradekoval comradekoval reopened this Apr 11, 2024
@comradekoval

Copy link
Copy Markdown
Contributor Author

You also REALLY want to delete cache from history, storing all that doesn't make too much sense.

@rockbmb

rockbmb commented Apr 12, 2024

Copy link
Copy Markdown
Contributor

You also REALLY want to delete cache from history, storing all that doesn't make too much sense.

You make a fair point; here's why I did i.

From yarn's documentation on "Which files should be gitignored?":

  • .yarn/cache and .pnp.* may be safely ignored, but you'll need to run yarn install to regenerate them between each branch switch - which would be optional otherwise, cf Zero-Installs.

Not having to run yarn install everytime one switches branches is a pleasant convenience, though this isn't a big project, nor is it used by that many people to justify keeping the cache in git's tree.

I can remove the cache from the tree in #3 .

@rockbmb

rockbmb commented Apr 12, 2024

Copy link
Copy Markdown
Contributor

Right, here's a bit more data on Yarn's zero installs: https://yarnpkg.com/features/caching#zero-installs

Zero-installs are the combination of two Yarn features that allow you to skip having to think about running yarn install when switching branches - a requirement otherwise easy to forget until you see your tools crash.

Zero-installs are technically possible by adding your node_modules folders to Git. The difference however is that node_modules folders contain multiple thousands of files that Git each has to diff individually, that the hoisting causes them to frequently be moved around, and that people have a bad tendency to make manual changes to their node_modules folder that end up committed.

By contrast, adding your cache to Git and using Yarn PnP gives you a single folder with exactly one zip archive for each package, plus the PnP loader file. This is vastly easier for Git to track, as we saw earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants