feat: make replaySafeHash wrapping optional with validation option #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancoombs
changed the base branch from
danc/skip-replay-hash-module-domain
to
develop
dancoombs
force-pushed
the
danc/skip-replay-hash-moduleentity
branch
from
6198497 to
f07232d
Compare
|
Contract sizes: | Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|------------------------------|------------------|-------------------|--------------------|---------------------|
| AccountFactory | 6,604 | 7,161 | 17,972 | 41,991 |
| Address | 16 | 44 | 24,560 | 49,108 |
| AllowlistModule | 10,148 | 10,174 | 14,428 | 38,978 |
| Base64 | 16 | 44 | 24,560 | 49,108 |
| Create2 | 16 | 44 | 24,560 | 49,108 |
| ECDSA | 16 | 44 | 24,560 | 49,108 |
| ERC165Checker | 16 | 44 | 24,560 | 49,108 |
| ERC1967Utils | 16 | 44 | 24,560 | 49,108 |
| ExecutionInstallDelegate | 5,835 | 5,880 | 18,741 | 43,272 |
| FCL_Elliptic_ZZ | 16 | 44 | 24,560 | 49,108 |
| FCL_ecdsa | 16 | 44 | 24,560 | 49,108 |
| Math | 16 | 44 | 24,560 | 49,108 |
| MessageHashUtils | 16 | 44 | 24,560 | 49,108 |
-| ModularAccount | 22,935 | 23,323 | 1,641 | 25,829 |
+| ModularAccount | 23,310 | 23,698 | 1,266 | 25,454 |
| NativeTokenLimitModule | 4,917 | 4,943 | 19,659 | 44,209 |
| PaymasterGuardModule | 2,028 | 2,054 | 22,548 | 47,098 |
| SafeERC20 | 16 | 44 | 24,560 | 49,108 |
-| SemiModularAccount7702 | 23,336 | 23,717 | 1,240 | 25,435 |
-| SemiModularAccountBytecode | 23,812 | 24,200 | 764 | 24,952 |
+| SemiModularAccount7702 | 23,426 | 23,807 | 1,150 | 25,345 |
+| SemiModularAccountBytecode | 23,902 | 24,290 | 674 | 24,862 |
| SignatureChecker | 16 | 44 | 24,560 | 49,108 |
| SignedMath | 16 | 44 | 24,560 | 49,108 |
-| SingleSignerValidationModule | 3,853 | 3,879 | 20,723 | 45,273 |
+| SingleSignerValidationModule | 3,564 | 3,590 | 21,012 | 45,562 |
| StorageSlot | 16 | 44 | 24,560 | 49,108 |
| Strings | 16 | 44 | 24,560 | 49,108 |
| TimeRangeModule | 2,435 | 2,461 | 22,141 | 46,691 |
| WebAuthn | 16 | 44 | 24,560 | 49,108 |
-| WebAuthnValidationModule | 9,277 | 9,303 | 15,299 | 39,849 |
+| WebAuthnValidationModule | 8,979 | 9,005 | 15,597 | 40,147 |Code coverage:
|
dancoombs
force-pushed
the
danc/skip-replay-hash-moduleentity
branch
3 times, most recently
from
6456bba to
9100d2b
Compare
dancoombs
force-pushed
the
danc/skip-replay-hash-moduleentity
branch
from
9100d2b to
3feddad
Compare
dancoombs
changed the title
adamegyed
approved these changes
Dec 19, 2025
Contributor
adamegyed
left a comment
adamegyed
left a comment
There was a problem hiding this comment.
LGTM, had one callout / design decision note
| /// enforcing the domain separator, which includes this contract's address, the chainId, and the validation | ||
| /// module & entity id. This is only relevant for 1271 validation because UserOp validation relies on the UO | ||
| /// hash and the Entrypoint has safeguards. | ||
| function replaySafeHash(bytes32 hash, ModuleEntity validationModuleEntity) public view returns (bytes32) { |
Contributor
There was a problem hiding this comment.
Making this public will increase bytecode size, and isn't strictly necessary (plus, doing an eth_call during txn prep is usually slow and requires implementation knowledge anyways.
But, this would make it easier to debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution