-
Couldn't load subscription status.
- Fork 85
feat: reset password #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reset password #937
Conversation
| const rootStateDir = path.join(process.cwd(), ".alchemy"); | ||
| const entries = await fs.promises.readdir(rootStateDir, { | ||
| withFileTypes: true, | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feels inherintly flawed since we store other things there (logs, miniflare data, etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That does look bad, yeah. State store is unfortunately legacy and really should be in its own folder under /.alchemy and not the root. Not sure how to achieve that for current users though.
|
Honestly the more I think about it the more I think |
Oh yeah, why's that? |
bulk potentially dangerous action that has limited usecases and isn't well supported by our underlying state stores just smells off |
aafee5a to
892c4aa
Compare
a3a4abd to
1eeb802
Compare
|
closing. this is just kind of not doable safely with the FS state store not being to identify all stages |
No description provided.