Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated results #8

Merged
merged 1 commit into from
Nov 2, 2024
Merged

updated results #8

merged 1 commit into from
Nov 2, 2024

Conversation

ternaus
Copy link
Contributor

@ternaus ternaus commented Nov 2, 2024

Summary by Sourcery

Add support for HSV transformation and update library versions in the benchmarking suite. Improve statistical calculations and update pre-commit configurations.

New Features:

  • Add support for HSV transformation in the benchmarking suite.

Enhancements:

  • Update the benchmarking suite to use the latest versions of libraries, including albumentations 1.4.21, numpy 2.1.3, torchvision 0.20.1, and ultralytics 8.3.27.
  • Improve the statistical calculation in the benchmarking suite by using the unbiased standard deviation (ddof=1).
  • Enhance the pre-commit configuration by updating ruff to v0.7.2 and pyproject-fmt to v2.5.0.

Documentation:

  • Update documentation to reflect the new library versions and benchmark parameters.

Copy link

sourcery-ai bot commented Nov 2, 2024

Reviewer's Guide by Sourcery

This PR updates benchmark results and adds support for ultralytics library and HSV transform. The changes include updating library versions, adding new transforms, and improving benchmark statistics calculation. The benchmark now runs 20 iterations instead of 10 for better statistical significance.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated benchmark parameters and results
  • Increased number of runs per transform from 10 to 20
  • Updated library versions (albumentations 1.4.21, torchvision 0.20.1)
  • Added standard deviation calculation with Bessel's correction (ddof=1)
  • Updated benchmark results for all transforms with new measurements
output/albumentations_results.json
output/kornia_results.json
output/imgaug_results.json
output/augly_results.json
output/comparison.md
README.md
Added support for ultralytics library and HSV transform
  • Added HSV transform implementation for albumentations
  • Added ultralytics to the list of benchmarked libraries
  • Added image loader support for ultralytics library
benchmark/transforms/albumentations_impl.py
benchmark/transforms/specs.py
benchmark/utils.py
run_all.sh
requirements/ultralytics.txt
Added missing transform implementations in imgaug
  • Added Brightness transform implementation
  • Added Contrast transform implementation
benchmark/transforms/imgaug_impl.py
Development environment updates
  • Updated ruff pre-commit hook to v0.7.2
  • Updated pyproject-fmt to v2.5.0
  • Added BLE001 to ruff ignore list
.pre-commit-config.yaml
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ternaus ternaus merged commit 3d202b5 into main Nov 2, 2024
1 check passed
@ternaus ternaus deleted the update_simsimd_stringzilla_benchmark branch November 2, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant