Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in plots #21

Merged
merged 5 commits into from
Mar 12, 2025
Merged

Fix in plots #21

merged 5 commits into from
Mar 12, 2025

Conversation

ternaus
Copy link
Contributor

@ternaus ternaus commented Mar 12, 2025

No description provided.

Copy link

sourcery-ai bot commented Mar 12, 2025

Reviewer's Guide by Sourcery

This pull request improves the speedup distribution plots by enhancing their aesthetics and readability using seaborn, and updates the minimum required Python version to 3.13. It also updates the development requirements.

Updated class diagram for plot_speedup_distribution function

classDiagram
    class plot_speedup_distribution{
        +comparison_df: DataFrame
        +reference_library: str
        +output_path: str
        +max_speedup: float
        +total_transforms: int
        +transforms_with_multiple_library_support: int
        +hist_color: str
        +top_color: str
        +bottom_color: str
        +fig: Figure
        +ax1: Subplot
        +ax2: Subplot
        +ax3: Subplot
        +typical_speedups: Series
        +top_10: DataFrame
        +bottom_10: DataFrame
        +stats_text: str
        +palette: list
        +plot_speedup_distribution(comparison_df, reference_library, output_path, max_speedup)
    }
    note for plot_speedup_distribution "Updated aesthetics using seaborn\nIncreased height for better spacing\nAdded color palette\nImproved text labels and positioning"
Loading

File-Level Changes

Change Details Files
Improved the aesthetics and readability of the speedup distribution plot.
  • Set seaborn style to "whitegrid" for better aesthetics.
  • Set seaborn context to "paper" with a font scale of 1.1.
  • Defined a color palette for consistent coloring of plot elements.
  • Increased the figure height for better spacing of subplots.
  • Removed the median speedup line and legend from the histogram.
  • Used sns.histplot instead of ax1.hist.
  • Used sns.barplot instead of ax2.barh and ax3.barh.
  • Removed y-label "Transform" from the bar plots.
  • Added text labels for speedup values on the bar plots.
  • Adjusted the position and appearance of the statistics text.
  • Increased the top margin for the suptitle.
  • Updated the bounding box style of the stats text.
tools/generate_speedup_plots.py
Updated the minimum required Python version to 3.13.
  • Changed requires-python to ">=3.13" in pyproject.toml.
  • Set target-version to py313 in pyproject.toml.
  • Set python_version to 3.13 in pyproject.toml.
pyproject.toml
Updated the development requirements.
  • Removed specific versions of packages.
requirements-dev.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider defining the color palette outside the function to avoid recomputation on every call.
  • It might be helpful to add a brief description of what the max_speedup parameter represents in the function's docstring.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ternaus ternaus merged commit 4c5ae81 into main Mar 12, 2025
1 check passed
@ternaus ternaus deleted the fix_plots branch March 12, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant