-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated benchmark for GaussBlur #17
Conversation
Reviewer's Guide by SourceryThis pull request updates the albumentations version in the benchmark, along with its corresponding performance in the README and comparison output files. It also updates the ruff and mypy pre-commit hook versions. Updated class diagram for benchmark versionsclassDiagram
class Albumentations {
-version: str = "2.0.4"
}
class Ruff {
-version: str = "v0.9.6"
}
class Mypy {
-version: str = "v1.15.0"
}
Albumentations -- Ruff
Albumentations -- Mypy
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a script to automatically update the benchmark results in the README and comparison files.
- It would be helpful to include the hardware and software environment used for benchmarking to ensure reproducibility.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
S
Summary by Sourcery
Updated the benchmark suite to reflect performance improvements in albumentations 2.0.4, particularly for GaussianBlur, and updated pre-commit hooks.
Enhancements:
Build:
CI: