Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated benchmark for GaussBlur #17

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Updated benchmark for GaussBlur #17

merged 1 commit into from
Feb 26, 2025

Conversation

ternaus
Copy link
Contributor

@ternaus ternaus commented Feb 18, 2025

S

Summary by Sourcery

Updated the benchmark suite to reflect performance improvements in albumentations 2.0.4, particularly for GaussianBlur, and updated pre-commit hooks.

Enhancements:

  • Improved the performance of the GaussianBlur transform.

Build:

  • Updated the albumentations dependency version in the benchmark suite to 2.0.4.

CI:

  • Updated ruff pre-commit hook to version v0.9.6.
  • Updated mypy pre-commit hook to version v1.15.0.

Copy link

sourcery-ai bot commented Feb 18, 2025

Reviewer's Guide by Sourcery

This pull request updates the albumentations version in the benchmark, along with its corresponding performance in the README and comparison output files. It also updates the ruff and mypy pre-commit hook versions.

Updated class diagram for benchmark versions

classDiagram
    class Albumentations {
        -version: str = "2.0.4"
    }

    class Ruff {
        -version: str = "v0.9.6"
    }

    class Mypy {
        -version: str = "v1.15.0"
    }

    Albumentations -- Ruff
    Albumentations -- Mypy
Loading

File-Level Changes

Change Details Files
Updated albumentations version and performance comparison in README and comparison output files.
  • Updated albumentations version from 2.0.3 to 2.0.4.
  • Updated performance comparison table with new benchmark results for albumentations 2.0.4.
  • The GaussianBlur transformation shows a significant performance increase.
README.md
output/comparison.md
Updated ruff pre-commit hook version.
  • Updated ruff pre-commit hook version from v0.9.4 to v0.9.6.
.pre-commit-config.yaml
Updated mypy pre-commit hook version.
  • Updated mypy pre-commit hook version from v1.14.1 to v1.15.0.
.pre-commit-config.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a script to automatically update the benchmark results in the README and comparison files.
  • It would be helpful to include the hardware and software environment used for benchmarking to ensure reproducibility.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ternaus ternaus merged commit ab6e84d into main Feb 26, 2025
1 check passed
@ternaus ternaus deleted the update_gauss_blur branch February 26, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant