Fix in PixelDropout

[ternaus]

Summary by Sourcery

This pull request fixes an issue with the PixelDropout transform where bounding boxes were not being correctly handled when the per_channel option was enabled. It also moves the PixelDropout transform to the dropout module.

Enhancements:

• Move PixelDropout transform to the dropout module.
• Improve the handling of bounding boxes in PixelDropout when per_channel is enabled.
• Improve the handling of keypoints in PixelDropout.
• Update ruff version.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request relocates the PixelDropout transform to the dropout module for better organization, improves mask handling in mask_dropout_bboxes and mask_dropout_keypoints, and updates the ruff pre-commit hook version.

Sequence diagram for PixelDropout::apply_to_bboxes

sequenceDiagram
    participant PixelDropout
    participant BboxProcessor
    participant fdropout
    participant fmain

    PixelDropout->PixelDropout: apply_to_bboxes(bboxes, drop_mask, params)
    alt drop_mask is None or per_channel is True
        PixelDropout-->PixelDropout: return bboxes
    else
        PixelDropout->PixelDropout: get_processor("bboxes")
        alt processor is None
            PixelDropout-->PixelDropout: return bboxes
        else
            PixelDropout->fmain: denormalize_bboxes(bboxes, image_shape)
            fmain-->PixelDropout: denormalized_bboxes
            alt per_channel and len(drop_mask.shape) > 2
                PixelDropout->np: any(drop_mask, axis=-1)
                np-->PixelDropout: combined_mask
            else
                PixelDropout->PixelDropout: combined_mask = drop_mask
            end
            PixelDropout->fdropout: mask_dropout_bboxes(denormalized_bboxes, combined_mask, image_shape, min_area, min_visibility)
            fdropout-->PixelDropout: result
            PixelDropout->fmain: normalize_bboxes(result, image_shape)
            fmain-->PixelDropout: normalized_bboxes
            PixelDropout-->PixelDropout: return normalized_bboxes
        end
    end

Loading

File-Level Changes

Change	Details	Files
Relocated PixelDropout from albumentations/augmentations/transforms.py to albumentations/augmentations/dropout/transforms.py to improve module organization.	Moved the PixelDropout class to the dropout module. Updated imports to reflect the new location of PixelDropout.	albumentations/augmentations/dropout/transforms.py albumentations/augmentations/transforms.py albumentations/augmentations/__init__.py
Implemented improvements to mask_dropout_bboxes and mask_dropout_keypoints functions to handle different mask dimensions and filter keypoints outside mask dimensions.	Modified mask_dropout_bboxes to ensure the dropout mask is 2D by squeezing or applying np.any along the channel axis. Added a check for keypoints outside the mask dimensions in mask_dropout_keypoints. Modified mask_dropout_keypoints to filter keypoints outside the mask dimensions.	albumentations/augmentations/dropout/functional.py
Updated ruff pre-commit hook version.	Updated ruff pre-commit hook version from v0.9.9 to v0.9.10.	.pre-commit-config.yaml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a test case that specifically checks the scenario where per_channel=True and its impact on bounding boxes.
• The logic for handling bounding boxes when per_channel is True seems complex; consider simplifying it if possible.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 2 issues found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}