Allow _cmp to return NAN, and handle comparisons with NAN properly.#317
Open
BenLubar wants to merge 1 commit intoalbertodemichelis:masterfrom
Open
Allow _cmp to return NAN, and handle comparisons with NAN properly.#317BenLubar wants to merge 1 commit intoalbertodemichelis:masterfrom
BenLubar wants to merge 1 commit intoalbertodemichelis:masterfrom
Conversation
Add NO_POINTER_CMP define which causes comparisons that would have compared pointers to throw instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
_cmpto returnNAN, and handle comparisons withNANproperly.Add
NO_POINTER_CMPdefine which causes comparisons that would have compared pointers to throw instead.Adds a new function (
sq_cmpex) which allows callers to observe whether the comparison isNANand whether the comparison completely failed.