Checking for minimum/maximum number of native closure parameters#288
Open
provigz wants to merge 2 commits intoalbertodemichelis:masterfrom
Open
Checking for minimum/maximum number of native closure parameters#288provigz wants to merge 2 commits intoalbertodemichelis:masterfrom
provigz wants to merge 2 commits intoalbertodemichelis:masterfrom
Conversation
The `sq_setparamscheck` function, instead of accepting just one `SQInteger nparamscheck` parameter, now accepts `SQInteger nparamscheckmin` and `SQInteger nparamscheckmax`. Those define the minimum/maximum for the parameters number check policy. Setting any of them to 0 or negative disables the respective check. This enables support for optional parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sq_setparamscheckfunction, instead of accepting just theSQInteger nparamscheckparameter, now accepts bothSQInteger nparamscheckminandSQInteger nparamscheckmax.Those define the minimum/maximum for the parameters number check policy. Setting any of them to 0 or negative disables the respective check.
I believe this change makes the parameter check way less restrictive and suitable for more use-cases. For example, it enables support for default arguments.
NOTE: This change makes changes to the API functions
sq_setparamscheckandsq_getclosureinfo. I am not sure how Squirrel handles such changes (deprecation mechanic?). Because of this, I understand that this change might not be suitable for upstream.