silence gcc fallthrough warnings#197
Open
fireice-uk wants to merge 1 commit intoalbertodemichelis:masterfrom
Open
silence gcc fallthrough warnings#197fireice-uk wants to merge 1 commit intoalbertodemichelis:masterfrom
fireice-uk wants to merge 1 commit intoalbertodemichelis:masterfrom
Conversation
Contributor
|
This is gross. you should use attribute((fallthrough)) instead after defining it to something else with a GNUC check. |
Author
|
Indeed, I'm just taking the path of least resistance here. I'm happy to rewrite to whatever attribute system is requested (if we are going to go that route defining one for clang might be pointful). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding this magic comment will stop gcc from crying out on default settings. For more info, see:
-Wimplicit-fallthrough=nsection inhttps://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
NOTE: I assume the four uncommented fallthroughs are intentional - I did not verify code correctness.