-
Notifications
You must be signed in to change notification settings - Fork 7
contributing #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
contributing #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. But a few of the references involve direct references to https://github.com/github/docs, so some links and images are broken as well. Can you change the wording and direct links so that they reference rsa-keygen
correctly and resolve correctly?
sorry for the problem i will do it. |
hey i have changed contributing section can u please check it out
Co-authored-by: Alan Yee <[email protected]>
sir please can u again check it out |
@hannykumar I still have some open pending comments on the file. Are you able to see them? |
i have done all the comment and resolved them other comments are not showing |
@hannykumar I have made/remade some comments. Are you able to see them now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sir can u please check it once and please can u accept my pr so that it can be counted on my hacktoberfest
@hannykumar I have checked your PR, and I have left comments on your PR. Please follow the comments, and I will gladly accept your PR. |
sir please review the changes |
@hannykumar You did not actually address the problems I pointed out in that comment. There are also three other comments I would like you to address. |
No description provided.