Skip to content

Conversation

hannykumar
Copy link

No description provided.

Copy link
Owner

@alanyee alanyee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. But a few of the references involve direct references to https://github.com/github/docs, so some links and images are broken as well. Can you change the wording and direct links so that they reference rsa-keygen correctly and resolve correctly?

@hannykumar
Copy link
Author

Thank you for your contribution. But a few of the references involve direct references to https://github.com/github/docs, so some links and images are broken as well. Can you change the wording and direct links so that they reference rsa-keygen correctly and resolve correctly?

sorry for the problem i will do it.

hey i have changed contributing section can u please check it out
@hannykumar
Copy link
Author

sir please can u again check it out

@alanyee
Copy link
Owner

alanyee commented Oct 21, 2021

@hannykumar I still have some open pending comments on the file. Are you able to see them?

@hannykumar
Copy link
Author

@hannykumar I still have some open pending comments on the file. Are you able to see them?

i have done all the comment and resolved them other comments are not showing

@alanyee
Copy link
Owner

alanyee commented Oct 21, 2021

@hannykumar I have made/remade some comments. Are you able to see them now?

Copy link
Author

@hannykumar hannykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sir can u please check it once and please can u accept my pr so that it can be counted on my hacktoberfest

@alanyee
Copy link
Owner

alanyee commented Oct 30, 2021

@hannykumar I have checked your PR, and I have left comments on your PR. Please follow the comments, and I will gladly accept your PR.

@hannykumar
Copy link
Author

sir please review the changes

@alanyee
Copy link
Owner

alanyee commented Oct 30, 2021

@hannykumar You did not actually address the problems I pointed out in that comment. There are also three other comments I would like you to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants