Open
Conversation
dfulu
approved these changes
Jan 8, 2025
Collaborator
dfulu
left a comment
dfulu
left a comment
There was a problem hiding this comment.
Thanks for taking the time to do this. Looks good!
Should we also put it in the Validation Dataset and the Datamodule or leave that for a later PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new keyword
return_time_featurestoSatelliteDataset, which returns features based on the time of day and where in the year we are. Taking the lead from AI weather models on this being useful (and indeed, I think it would help add a correlate for the dark patches in visible channels). See e.g.https://github.com/google-deepmind/graphcast/blob/6819a0f19796ca9c34a079855339b37134b8d930/graphcast/graphcast.py#L122C1-L127C2