Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: menu group - default expand option #1389

Merged
merged 16 commits into from
Oct 27, 2022
Merged

feature: menu group - default expand option #1389

merged 16 commits into from
Oct 27, 2022

Conversation

whitestranger7
Copy link
Contributor

@whitestranger7 whitestranger7 commented Mar 28, 2021 •
edited
Loading

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1265
Related Kitten Tricks PR.

@whitestranger7 whitestranger7 mentioned this pull request Mar 28, 2021
Open
1 task
@whitestranger7 whitestranger7 changed the title feature: menu group - default expand feature: menu group - default expand option Mar 28, 2021
@github-actions
Copy link

Try running it with Kitten Tricks

.

artyorsh
artyorsh reviewed Mar 29, 2021
View reviewed changes
Copy link
Collaborator

@artyorsh artyorsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confusing property naming. Should have initial prefix or something else letting users know we aren't using it to control the component state after its initial render.

src/showcases/components/menu/menuGroups.component.tsx Outdated Show resolved Hide resolved
@whitestranger7 whitestranger7 requested a review from artyorsh March 29, 2021 15:58
@whitestranger7 whitestranger7 force-pushed the feature/menuGroup/defaultExpand branch from e2b5503 to 41f21c4 Compare March 30, 2021 17:20
@Joeao
Copy link

Joeao commented Sep 12, 2021

What's the status with this?

@Valeour
Copy link

Valeour commented Sep 16, 2021

This helped solve an issue we were having, thank you!

@exzos28
Copy link

exzos28 commented Jun 18, 2022

any updates?

@github-actions
Copy link

Try running it with Kitten Tricks

.

@github-actions
Copy link

Try running it with Kitten Tricks

.

1 similar comment
@github-actions
Copy link

Try running it with Kitten Tricks

.

@greenfrvr greenfrvr mentioned this pull request Oct 26, 2022
Closed
@greenfrvr greenfrvr merged commit 30e2a5c into master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayres sayres sayres approved these changes

@artyorsh artyorsh Awaiting requested review from artyorsh

@malashkevich malashkevich Awaiting requested review from malashkevich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MenuGroup missing props - expanded by default?
8 participants
@whitestranger7 @Joeao @Valeour @exzos28 @malashkevich @sayres @artyorsh @greenfrvr