Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aiprdbms #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Aiprdbms #22

wants to merge 2 commits into from

Conversation

arm2arm
Copy link

@arm2arm arm2arm commented Mar 30, 2022

looks good and working on pg14 + pg_gis

arm2arm added 2 commits March 30, 2022 13:04
@arm2arm
to avoid **-Werror=vla** error
4e65430 
using dynamic arrays to avoid  **-Werror=vla** error
@arm2arm
dynamic array to avoid -Werror=vla error
85ffd5c 
moving to dynamic allocated array to avoid  -Werror=vla error
@esabol
Copy link

esabol commented Mar 31, 2022

Shouldn't you be using palloc and pfree instead of malloc and free?

@arm2arm
Copy link
Author

arm2arm commented Mar 31, 2022

what is the difference? if palloc is a postgres way to go then palloc is also good 😊

@esabol
Copy link

esabol commented Mar 31, 2022

I don't know, but I think palloc is what you're supposed to use in PostgreSQL extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arm2arm @esabol