Skip to content

Adjustments for ember-v2 branch#2

Merged
aklkv merged 11 commits into
aklkv:feat/ember-v2-formatfrom
getsentry:fn/ember-v2-adjustments
May 20, 2026
Merged

Adjustments for ember-v2 branch#2
aklkv merged 11 commits into
aklkv:feat/ember-v2-formatfrom
getsentry:fn/ember-v2-adjustments

Conversation

@mydea
Copy link
Copy Markdown

@mydea mydea commented May 18, 2026

This PR adds some adjustments to the getsentry#19229 PR branch:

  1. Run yarn fix at repo root to ensure consistent formatting
  2. Streamline stuff a bit, esp. around timing and the browser tracing integration. There were some quirks there apparently with the setTimeout approach in a strict resolver app. This PR changes the behavior to always start the pageload span immediately, even if no router/location is available yet, and simply updates this when it gets the data later. this is more aligned with other SDKs as well and should be safer too, it seems to work in all ember test apps.
  3. Add a ember-strict-resolver test app and remove the demo app from the ember package itself.
  4. fix the ember-vite test app
  5. Add a instrumentEmberAppPerformance export as core utility to use
  6. Removed loads of dependencies we no longer need for the core ember package

};
}

// Manually register instance initializers
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea if there is another way to make this work, couldn't find any docs or examples around this, but this seems to work...

@aklkv aklkv merged commit 44712d2 into aklkv:feat/ember-v2-format May 20, 2026
4 of 5 checks passed
aklkv pushed a commit that referenced this pull request May 20, 2026
* improvements for ember-v2

* remove addon files??

* remove config

fix version

* fix test app

* fixes and stuff

* moar fixes

* small ref

* rename to strict resolver

* add instrumentAppInstancePerformance

* fix ember-vite app

* fix type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants