Skip to content

test: Harden EventSourcedCleanupSpec, #549 #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024
Merged

test: Harden EventSourcedCleanupSpec, #549 #584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions core/src/test/scala/akka/persistence/r2dbc/cleanup/scaladsl/EventSourcedCleanupSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,13 @@ class EventSourcedCleanupSpec

// find two different persistenceIds that are both in the slice range 0-255 so that this test can run with
// 4 data partitions
private def pidsWithSliceLessThan256(entityType: String) = {
private def pidsWithDifferentSlicesLessThan256(entityType: String) = {
var pid1: PersistenceId = null
var pid2: PersistenceId = null
while (pid1 == pid2 || persistenceExt.sliceForPersistenceId(pid1.id) > 255 || persistenceExt
.sliceForPersistenceId(pid2.id) > 255) {
def slice1 = persistenceExt.sliceForPersistenceId(pid1.id)
def slice2 = persistenceExt.sliceForPersistenceId(pid2.id)

while (pid1 == pid2 || slice1 == slice2 || slice1 > 255 || slice2 > 255) {
pid1 = PersistenceId(entityType, UUID.randomUUID().toString)
pid2 = PersistenceId(entityType, UUID.randomUUID().toString)
}
Expand Down Expand Up @@ -393,7 +395,7 @@ class EventSourcedCleanupSpec
val ackProbe = createTestProbe[Done]()
val entityType = nextEntityType()

var (pid1, pid2) = pidsWithSliceLessThan256(entityType)
var (pid1, pid2) = pidsWithDifferentSlicesLessThan256(entityType)

val p1 = spawn(Persister(pid1))
val p2 = spawn(Persister(pid2))
Expand Down