Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compression negotiation #1898

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix compression negotiation #1898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions runtime/src/main/scala/akka/grpc/internal/Codecs.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,8 @@ object Codecs {
* @return a codec to compress data frame bodies with, which will be [[Identity]] unless the client specifies support for another supported encoding.
*/
def negotiate(request: jm.HttpRequest): Codec = {
val accepted: Array[String] =
request.asInstanceOf[sm.HttpMessage].header[`Message-Accept-Encoding`] match {
case Some(h) => h.values
case None => Array.empty
}
// DO NOT USE request.header[`Message-Accept-Encoding`], as that doesn't work for custom headers
val accepted = `Message-Accept-Encoding`.findIn(request.asInstanceOf[sm.HttpMessage].headers)

if (accepted.length == 0) {
Identity
Expand Down
Loading