Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gui_widgets #360

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support gui_widgets #360

wants to merge 3 commits into from

Conversation

akiyosi
Copy link
Owner

@akiyosi akiyosi commented May 30, 2022

This PR supports the generic image and text label display plugin gui_widgets.nvim, created by @yatli, for the Neovim GUI frontend.
2022-05-30 23 48 39

@yatli
Copy link

yatli commented May 31, 2022

Nice gopher potatoe :p
Glad to see the progress here!

@bezmi
Copy link

bezmi commented Sep 23, 2022

Have you got a little time to explain how to test this (like in your screenshot)? I have tried installing @yatli plugin and opening/reloading a markdown file, but i see no changes to the rendering. I have been able to get the same functionality working in fvim with the olugin in the gui_widgets repo (albeit buggy) so i wanted to compare the two.

@akiyosi
Copy link
Owner Author

akiyosi commented Sep 24, 2022

@bezmi
Thanks for the info.
If you have installed gui_widgets.nvim, you should be able to open the markdown file and see gui_widgets without any additional configuration required.

In my environment, I have added "-k" to the curl options, but if you are having no problems with fvim displaying images, etc in your environment, then you should not need to do this either.

I think there is something wrong with the current implementation.
By the way, what is your OS?

@bezmi
Copy link

bezmi commented Sep 24, 2022

I'm on archlinux, testing using build artifacts from your latest push and the latest HEAD of neovim. Turns out launching directly from the shell with goneovim filename.md doesn't work. If I launch goneovim and then navigate to the file, the widgets are rendered. Since I was testing anyway, I've attached a screencast of how it behaves for your reference. Happy for you to @ me for testing.

Screencast.from.09-24-2022.03.10.25.PM.webm

@akiyosi
Copy link
Owner Author

akiyosi commented Sep 25, 2022

@bezmi
Thanks for the info.
I have also checked, and indeed gui_widgets does not display well in the use case where a markdown file is specified at startup, like the following.

/path/to/goneovim SOMEFILE.md

Perhaps this is due to the markdown file being loaded before the RPC connection process in the internal initialization process.
I understand that this is the same situation in fvim as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants