Skip to content

fix(#2017): Dots state error when SlideToshow uses decimal value and … #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(#2017): Dots state error when SlideToshow uses decimal value and … #2306

wants to merge 1 commit into from

Conversation

vishwajeet1
Copy link

Issue: #2017

solution

  1. Round off values in JavaScript calculations because reliability issues arise with decimal values.
  2. When calculating the leftBound, use slidesToShow instead of 1, as the last active slide will be slideCount - slidesToShow.

@vishwajeet1 vishwajeet1 mentioned this pull request Dec 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vishwajeet1