Added EdgeKV lib d.ts module. #142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayoub-akamai
suggested changes
Jun 10, 2022
Contributor
kayoub-akamai
left a comment
kayoub-akamai
left a comment
There was a problem hiding this comment.
I've added comments where I think things might not be accurate... I'm curious how we expect customers to use this file?
| group?: string; | ||
| item: string; | ||
| value: T; | ||
| timeout?: number; |
Contributor
There was a problem hiding this comment.
can't this be null too?
| namespace?: string; | ||
| group?: string; | ||
| item: string; | ||
| timeout?: number | null; |
Contributor
There was a problem hiding this comment.
don't think this one has a timeout?
| } | ||
|
|
||
| export declare class EdgeKV { | ||
| constructor(namespace?: string, group?: string, num_retries_on_timeout?: number); |
Contributor
There was a problem hiding this comment.
Not sure how to indicate this, but it takes two constructors:
- is constructor(namespace?: string, group?: string)
- is constructor(item: EdgeKVConstructor)
where
interface EdgeKVConstructor {
namespace?: string;
group?: string;
num_retries_on_timeout?: number;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.