Skip to content

Potential fix for code scanning alert no. 134: Incomplete multi-character sanitization #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aka76bm merged 1 commit into from
Oct 23, 2025
Merged

Potential fix for code scanning alert no. 134: Incomplete multi-character sanitization #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tools/doc/json.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,14 +371,23 @@
const leadingHyphen = /^-\s*/;
const defaultExpr = /\s*\*\*Default:\*\*\s*([^]+)$/i;

function replaceAllHtmlComments(str) {

Check failure on line 374 in tools/doc/json.mjs

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

'replaceAllHtmlComments' is defined but never used
let prev;
do {
prev = str;
str = str.replace(/<!--.*?-->/sg, '');
} while (str !== prev);
return str;
}

function parseListItem(item, file) {
const current = {};

current.textRaw = item.children.filter((node) => node.type !== 'list')
.map((node) => (
file.value.slice(node.position.start.offset, node.position.end.offset)),
)
.join('').replace(/\s+/g, ' ').replace(/<!--.*?-->/sg, '');
.join('').replace(/\s+/g, ' ').replaceAllHtmlComments('');
let text = current.textRaw;

if (!text) {
Expand Down
Loading