Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to not autoreload on change to configuration #99

Closed
wants to merge 2 commits into from

Conversation

cwood
Copy link

@cwood cwood commented Jul 12, 2016

We use this to roll out our deployment so we can have puppet manage the configuration but only when we are ready to reread/update when our servers are out of the LB.

@ajcrowe
Copy link
Owner

ajcrowe commented Aug 2, 2016

Hi @cwood,

This looks a nice addition, couple of things could you:

  • Apply this to the other define types
    • fcgi_program
    • eventlistener
    • ctlplugin
    • rpcinterface
  • Run puppet lint over the code

Tests for this would be great but not essential.

@caiohasouza
Copy link

+1

@cwood
Copy link
Author

cwood commented Dec 19, 2016

Hey @ajcrowe yea I can do that. Ill hopefully be able to get to this soon.

@ajcrowe
Copy link
Owner

ajcrowe commented Aug 4, 2018

Closing as #122 is now merged. Thanks for getting this going @cwood

@ajcrowe ajcrowe closed this Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants