fix: simplify banner to avoid rendering issues#24
Merged
Conversation
- Replace backslash characters with pipe characters to avoid escape sequence issues - Banner now renders correctly as 'gitclaw' on all terminals - Replace emoji symbols with bracketed text ([OK], [INFO], [WARN], [ERR]) - Fixes emoji spacing issues and improves cross-platform compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The figlet banner was rendering incorrectly:
Solution
Testing
Tested with:
/ | / | / |/ |/ | / | / | / | / |$$/ $$ | $$ |$$/ $$ | $$ | $/ $ $ |$$ $$/ $$ $$/
$$/ $$ / $$$$$$/ $$/ $$ / $$/ $$ $$$$/ $$$$$$$/
/$$$$$$ |$$ | $$ |$$$$$$$$/ $$ | /$$ |/$$$$$$ |$$ | $$ |
$$ |$$ |$$ | $$ | $$ | $$ | /$$$ |$$ |
$$ $$ |$$ | $$ | $$ | $$ | /$$$$ |$$ | $$ | $$ |
$$$$$$$$ |$$ | $$ | $$ | $$ |$$/$$ |$$ | __ $$ | $$ |
$$ | $$ |$$ |$$ | $$ | $$ |$$$/ $$ |$$ |/ |$$ |$$ |
$$ | $$ |$$
/ |___
$$/
[INFO] No packages installed. Use 'gitclaw install user/repo' to get started. - Banner shows 'gitclaw' correctly
/ | / | / |/ |/ | / | / | / | / |$$/ $$ | $$ |$$/ $$ | $$ | $/ $ $ |$$ $$/ $$ $$/
$$/ $$ / $$$$$$/ $$/ $$ / $$/ $$ $$$$/ $$$$$$$/
/$$$$$$ |$$ | $$ |$$$$$$$$/ $$ | /$$ |/$$$$$$ |$$ | $$ |
$$ |$$ |$$ | $$ | $$ | $$ | /$$$ |$$ |
$$ $$ |$$ | $$ | $$ | $$ | /$$$$ |$$ | $$ | $$ |
$$$$$$$$ |$$ | $$ | $$ | $$ |$$/$$ |$$ | __ $$ | $$ |
$$ | $$ |$$ |$$ | $$ | $$ |$$$/ $$ |$$ |/ |$$ |$$ |
$$ | $$ |$$
/ |___
$$/
Detected platform: linux aarch64
Compiled for: Linux
OS aliases: ["linux"]
Arch aliases: ["aarch64", "arm64"] - Styled output with bracketed symbols