Avro time converter respects timezone #24
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses this bug (internally reported by me during S3 testing)
When a time with a timezone is converted to time of day, the timezone is ignored:
Given some input data like
The output is
When we should expect
**NOTE: I'm doing this here and not in the PR that implements new style field conversions, because there is currently no way to pass
logicalType="time-micros"
through after converting a timestamp to a long in json-schema. I decided to hold off until refactoring it for the CDK (which will entail changing the schema mapper from using json-schema to using a bespoke airbyte type + migrating avro schema and record processing to the schema/record mappers).Checklist
README.md