Epic 8349 certify s3/issue 8556 s3 v2 fields #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnny-schmidt
assigned gisripa and stephane-airbyte and unassigned stephane-airbyte and gisripa
|
Removed assignees because I need to implement @stephane-airbyte 's requested changes, and I might tweak it a bit for safety purposes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
airbytehq/json-avro-converteras the base repository, instead of the defaultallegro/json-avro-converter.Summary
This is to provide support for capturing field-level conversion failures when converting from json to avro. It adds a
FieldConversionFailureListeneroption to the record reader, which provides a hook for replacing the field value and adding metadata to the record when a failure occurs.Most of the changes here are to support that. Additionally I had to thread the original field name through the reader so that it could be added to the metadata if needed. (Sometimes the field name is edited to make it avro compatible.)
Checklist
README.mdReviewers