Skip to content

Source-Hubspot - Update Check Steam to Prevent OOM #60985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

agarctfi
Copy link
Contributor

What

OC Issue: https://github.com/airbytehq/oncall/issues/7947

Some streams are OOM'ing (137) on CHECK. The current stream used for this contacts requires multiple outbound requests to pass. We will switch it to Owners, since it requires fewer outbound requests to pass and still verifies that the config provided by the user is good.

How

Update manifest:

check:
  type: CheckStream
  stream_names:
    - owners

Also updated read.me to have the Docker commands for Hubspot, since this is now a manifest-only connector, it is useful to have those referenced in the read.me when debugging.

First, we will test via Dev Images. If it passes, we will proceed with the merge. Otherwise, we will consider increasing the resource requirements in addition to this change.

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • [ X] YES 💚
  • NO ❌

@agarctfi agarctfi requested a review from a team as a code owner May 29, 2025 19:52
Copy link

vercel bot commented May 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2025 4:28pm

Copy link
Contributor

github-actions bot commented May 29, 2025

source-hubspot Connector Test Results

146 tests   143 ✅  21m 7s ⏱️
  1 suites    0 💤
  1 files      3 ❌

For more details on these failures, see this check.

Results for commit 8ad23bb.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

pending this fix working, i assume we would merge this in after

Copy link
Collaborator

@darynaishchenko darynaishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
agree with changing stream for check command (see comment).
on other hand it's changing required scope for check, so we may have more config errors on check for some period, when users need to add crm.objects.owners.read, but I think it's acceptible.

@agarctfi agarctfi changed the title (Do Not Merge): Source-Hubspot - Update Check Steam to Prevent OOM Source-Hubspot - Update Check Steam to Prevent OOM May 30, 2025
@agarctfi agarctfi changed the title Source-Hubspot - Update Check Steam to Prevent OOM Source-Hubspot - Update Check Steam to Prevent OOM & Increase check memory to 1GB May 30, 2025
@agarctfi agarctfi changed the title Source-Hubspot - Update Check Steam to Prevent OOM & Increase check memory to 1GB Source-Hubspot - Update Check Steam to Prevent OOM May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants