Load CDK Tests: Expand coverage of funky characters #52067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
edgao
approved these changes
Jan 21, 2025
| @@ -106,6 +106,7 @@ abstract class IntegrationTest( | |||
| val actualRecords: List<OutputRecord> = dataDumper.dumpRecords(config, stream) | |||
| val expectedRecords: List<OutputRecord> = | |||
| canonicalExpectedRecords.map { recordMangler.mapRecord(it, stream.schema) } | |||
| val descriptor = recordMangler.mapStreamDescriptor(stream.descriptor) | |||
There was a problem hiding this comment.
why have this on the record mangler, rather than requiring the data dumper to do it transparently?
|
|
||
| @Test | ||
| @Disabled( | ||
| "Re-enabled for https://github.com/airbytehq/airbyte-internal-issues/issues/11424; TODO: fix glue" |
There was a problem hiding this comment.
can you add a link to https://github.com/airbytehq/airbyte-internal-issues/issues/11439 in this comment?
johnny-schmidt
force-pushed
the
jschmidt/load-cdk/missing-test-cases-reenable-funky
branch
from
9abbf7b to
60d2d64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL CI IS WORKING, THIS MAKES A LOT OF CHANGES TO TESTS
What
Expands coverage of
testFunkyCharactersto includeI also found an issue in the path matching code that fails to properly escape the path matching stuff if the stream name contains legal regex. (This is also an issue with the old CDK.) I went ahead and fixed it
This breaks the recently reenabled test for glue, so I re-disabled it. @edgao I'll leave it to you to decide whether to bother renabling, and whether that means patching or adding parameters to the test.