-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destinations snowflake+bigquery: Improve performance by filtering raw table on extracted_at #31191
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I focused just on the SQL. Some nits, and a perf question, but nothing blocking.
.../airbyte/integrations/destination/snowflake/typing_deduping/SnowflakeDestinationHandler.java
Outdated
Show resolved
Hide resolved
...src/test/java/io/airbyte/integrations/base/destination/typing_deduping/MockSqlGenerator.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
destination-bigquery test report (commit
|
Step | Result |
---|---|
Build connector tar | ✅ |
Java Connector Unit Tests | ✅ |
Build destination-bigquery docker image for platform(s) linux/x86_64 | ✅ |
Java Connector Integration Tests | ✅ |
Validate metadata for destination-bigquery | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-bigquery test
destination-snowflake test report (commit
|
Step | Result |
---|---|
Build connector tar | ✅ |
Java Connector Unit Tests | ✅ |
Build destination-snowflake docker image for platform(s) linux/x86_64 | ✅ |
Java Connector Integration Tests | ✅ |
Validate metadata for destination-snowflake | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-snowflake test
… table on extracted_at (airbytehq#31191) Co-authored-by: edgao <[email protected]>
closes #28380; based on airbytehq/typing-and-deduping-sql#23
Adds a
_airbyte_extracted_at > ?
filter to two queries in T+D:_airbyte_loaded_at = current_timestamp
And adds three tests to exercise this behavior.
This is a somewhat nontrivial change, so I'll roll it out to the internal workspace for bigquery first. If that works then I'll do a full release for both bigquery and snowflake (since the logic is basically identical for both destinations).