Skip to content

Commit

Permalink
also do for iceberg
Browse files Browse the repository at this point in the history
  • Loading branch information
edgao committed Jan 18, 2025
1 parent 81dd6cc commit 13b1d37
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package io.airbyte.integrations.destination.s3_data_lake

import com.fasterxml.jackson.databind.JsonNode
import com.fasterxml.jackson.databind.ObjectMapper
import io.airbyte.cdk.load.command.aws.asMicronautProperties
import io.airbyte.cdk.load.test.util.DestinationCleaner
import io.airbyte.cdk.load.test.util.NoopDestinationCleaner
import io.airbyte.cdk.load.write.BasicFunctionalityIntegrationTest
Expand All @@ -24,7 +25,6 @@ import org.junit.jupiter.api.Test
abstract class S3DataLakeWriteTest(
configContents: String,
destinationCleaner: DestinationCleaner,
envVars: Map<String, String> = emptyMap(),
) :
BasicFunctionalityIntegrationTest(
configContents,
Expand All @@ -33,6 +33,8 @@ abstract class S3DataLakeWriteTest(
destinationCleaner,
S3DataLakeExpectedRecordMapper,
additionalMicronautEnvs = S3DataLakeDestination.additionalMicronautEnvs,
micronautProperties =
S3DataLakeTestUtil.getAwsAssumeRoleCredentials().asMicronautProperties(),
isStreamSchemaRetroactive = true,
supportsDedup = true,
stringifySchemalessObjects = true,
Expand All @@ -42,7 +44,6 @@ abstract class S3DataLakeWriteTest(
preserveUndeclaredFields = false,
commitDataIncrementally = false,
supportFileTransfer = false,
envVars = envVars,
allTypesBehavior =
StronglyTyped(
integerCanBeLarge = false,
Expand Down Expand Up @@ -118,7 +119,6 @@ class GlueAssumeRoleWriteTest :
S3DataLakeTestUtil.getAwsAssumeRoleCredentials()
)
),
S3DataLakeTestUtil.getAwsAssumeRoleCredentialsAsMap()
)

@Disabled(
Expand Down

0 comments on commit 13b1d37

Please sign in to comment.