Skip to content

tests: re-enable file-based connector (google-drive) in CDK downstream connector tests #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Apr 18, 2025

This PR re-enables testing for the source-s3 source-google-drive connector in automated workflows. Previously this was commented out because it was too-far behind the latest version of the CDK. Now that the connector is caught up, this addition in the CDK will help us detect unexpected breakages.

Test running here:

UPDATE: The above failed due to disk space. I don't know if that was an interim hiccup or something more serious. However it worked find for source-google-drive so I'm using that connector as suggested by @aldogonzalez8 in DM.

Success log here:

image

I will only merge if the test completes successfully, and will revert my dummy commit if so.

Summary by CodeRabbit

  • Chores
    • Updated workflow comments for accuracy regarding connector status.
    • Added source-google-drive connector to the test matrix.

@Copilot Copilot AI review requested due to automatic review settings April 18, 2025 20:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables the file-based S3 connector in the CDK downstream connector tests. The key changes include uncommenting the S3 connector configuration and updating the workflow to run tests using the file-based connector.

Copy link
Contributor

coderabbitai bot commented Apr 18, 2025

📝 Walkthrough

Walkthrough

This change updates the .github/workflows/connector-tests.yml file by correcting a comment to accurately reflect the number of connectors lagging in CDK updates and by adding a new entry for the source-google-drive connector with a cdk_extra value of file-based to the connector test matrix. No other workflow logic or matrix entries were altered.

Changes

File(s) Change Summary
.github/workflows/connector-tests.yml Corrected a comment about connectors behind in CDK updates, and added source-google-drive with cdk_extra: file-based to the test matrix. No other changes made.

Possibly related PRs

Suggested labels

ci

Would you like to consider any additional context or connectors for the test matrix, or does this cover your current needs—wdyt?


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7976b55 and b30abea.

📒 Files selected for processing (1)
  • .github/workflows/connector-tests.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/connector-tests.yml
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Pytest (Fast)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

♻️ Duplicate comments (1)
.github/workflows/connector-tests.yml (1)

78-78: Comment on line 78 remains accurate: The note about destination‑pinecone being behind in CDK updates still applies to that connector. It’s fine to leave this comment as‑is, wdyt?

🧹 Nitpick comments (1)
airbyte_cdk/sources/file_based/discovery_policy/__init__.py (1)

9-10: Remove placeholder comment: The # dummy change (revert me) line appears to be a leftover placeholder without any functional impact. Consider removing it to keep the codebase clean, wdyt?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 331dc86 and 3503e09.

📒 Files selected for processing (2)
  • .github/workflows/connector-tests.yml (1 hunks)
  • airbyte_cdk/sources/file_based/discovery_policy/__init__.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Check: 'source-pokeapi' (skip=false)
  • GitHub Check: Check: 'source-amplitude' (skip=false)
  • GitHub Check: Check: 'source-s3' (skip=false)
  • GitHub Check: Check: 'source-shopify' (skip=false)
  • GitHub Check: Check: 'source-hardcoded-records' (skip=false)
  • GitHub Check: Pytest (All, Python 3.11, Ubuntu)
  • GitHub Check: Pytest (Fast)
  • GitHub Check: Pytest (All, Python 3.10, Ubuntu)
🔇 Additional comments (1)
.github/workflows/connector-tests.yml (1)

81-82: Re-enable source-s3 connector: Great to see source-s3 back in the matrix with cdk_extra: file-based. Could you verify that the file-based filter in the cdk_changes step correctly gates this job so it only runs when file-based code changes occur? wdyt?

Copy link
Contributor

@aldogonzalez8 aldogonzalez8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED

@aaronsteers
Copy link
Contributor Author

Thanks, @aldogonzalez8 ! 🙏

@aaronsteers aaronsteers changed the title tests: re-enable file-based connector (s3) in CDK downstream connector tests tests: re-enable file-based connector (google-drive) in CDK downstream connector tests Apr 19, 2025
@aaronsteers aaronsteers enabled auto-merge (squash) April 19, 2025 01:11
@aaronsteers aaronsteers merged commit b148ca5 into main Apr 19, 2025
23 checks passed
@aaronsteers aaronsteers deleted the aj/tests--re-enable-file-based-connector-(s3)-in-CDK-downstream-connector-tests branch April 19, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants