Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use reviewdog for inline PR annotations #253

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

ci: use reviewdog for inline PR annotations #253

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5592a1f
ci: replace mypy check with reviewdog for pr comments inline
aaronsteers Jan 23, 2025
39a8436
dummy change: remove return type annotation
aaronsteers Jan 23, 2025
a652a0a
fix: fail_on_error
aaronsteers Jan 23, 2025
71047bf
Apply suggestions from code review
aaronsteers Jan 23, 2025
5bf888f
ci[fix]: add target
aaronsteers Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/python_lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ jobs:
run: poetry install --all-extras

# Job-specific step(s):

- name: Run mypy
run: poetry run mypy --config-file mypy.ini airbyte_cdk
- uses: tsuyoshicho/action-mypy@v5
with:
github_token: ${{ secrets.github_token }}
# Change reviewdog reporter if you need [github-pr-check,github-check,github-pr-review].
reporter: github-pr-review
level: error
execute_command: 'poetry run mypy'
fail_on_error: true
target: airbyte_cdk
Loading