Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup _pandas #94

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cleanup _pandas #94

wants to merge 1 commit into from

Conversation

danfrankj
Copy link
Collaborator

@danfrankj danfrankj commented Jan 25, 2019 •
edited
Loading

pandas finally merged in the multi-values insert so we no longer need it here.

Tested with a sqlalchemy client

@matthewwardrop
Copy link
Collaborator

Thanks for staying on top of this. This does bump our dependency on pandas to a very recent version, which may be concerning to some deployments. Do you think we should defer merging this for a while, or just go for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewwardrop matthewwardrop matthewwardrop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danfrankj @matthewwardrop @danfrankcb