Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redis database duct #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add redis database duct #59

wants to merge 1 commit into from

Conversation

danfrankj
Copy link
Collaborator

@danfrankj danfrankj commented Jul 20, 2018

Summary

Redis as a database Duct

@danfrankj danfrankj requested a review from matthewwardrop July 20, 2018 19:45
@matthewwardrop
Copy link
Collaborator

Thanks for the patch Dan! I don't have much (if any) direct experience with Redis, but it seems like this implementation might be better implemented as a Restful instance? Or perhaps a new nosql class of database ducts? There are more exceptions to the rule here than there are similarities. What do you think?

@danfrankj
Copy link
Collaborator Author

Yeah @matthewwardrop this is a bit of a stretch to fit into the Database format... do you have any thoughts on how a NoSQL duct would be different from our Database ducts?

@matthewwardrop
Copy link
Collaborator

@danfrankj NoSQL databases are pretty free-form, and different implementations support different functionality. Do you think it makes sense to have a uniform API? If not, maybe we can just wrap other clients and provide the duct connection functionality, but otherwise expose the methods of the hosted client? Otherwise, perhaps we could commit to a simple api, like: "get", "set", "find"; and expose the wrapped client for more advanced functionality?

@danfrankj
Copy link
Collaborator Author

@matthewwardrop agreed - this is a bit of a stretch. I like the idea of a wrapper duct though. Will play around with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants