Include deserialized assets in the submission endpoint#727
Open
pratyush07-hub wants to merge 1 commit intoaiondemand:developfrom
Open
Include deserialized assets in the submission endpoint#727pratyush07-hub wants to merge 1 commit intoaiondemand:developfrom
pratyush07-hub wants to merge 1 commit intoaiondemand:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change(s)
Change Type: Fixed
Change Category: Interface
Changelog Entry: Include deserialized assets in the submission endpoint response.
The
GET /submissions/{identifier}endpoint now returns assets in their fully deserialized "Read" format, including nested relationships like application_area, keyword, scientific_domain, etc. This is achieved by applying the same orm_to_read converters used in the/user/resourcesendpoint. The response schema documentation is also improved to show all possible asset types.How to Test
1. Run the automated tests:
python -m pytest src/tests/authorization/test_authorization.py -k "test_get_submission_by_id"All 4 tests should pass
2.Start the server with
./scripts/up.shand navigate to http://localhost/docs. Find theGET /submissions/{identifier}endpoint, the response schema should now show all asset types with their full fields (including aiod_entry, keyword ,application_area, etc.).Checklist
Related Issues
Closes #525