Skip to content

Include deserialized assets in the submission endpoint#727

Open
pratyush07-hub wants to merge 1 commit intoaiondemand:developfrom
pratyush07-hub:issue-525-deserialized-assets
Open

Include deserialized assets in the submission endpoint#727
pratyush07-hub wants to merge 1 commit intoaiondemand:developfrom
pratyush07-hub:issue-525-deserialized-assets

Conversation

@pratyush07-hub
Copy link

Change(s)

Change Type: Fixed

Change Category: Interface

Changelog Entry: Include deserialized assets in the submission endpoint response.

The GET /submissions/{identifier} endpoint now returns assets in their fully deserialized "Read" format, including nested relationships like application_area, keyword, scientific_domain, etc. This is achieved by applying the same orm_to_read converters used in the /user/resources endpoint. The response schema documentation is also improved to show all possible asset types.

How to Test

1. Run the automated tests:
python -m pytest src/tests/authorization/test_authorization.py -k "test_get_submission_by_id"
All 4 tests should pass

2.Start the server with ./scripts/up.sh and navigate to http://localhost/docs. Find the GET /submissions/{identifier} endpoint, the response schema should now show all asset types with their full fields (including aiod_entry, keyword ,application_area, etc.).

Checklist

  • Tests have been added or updated to reflect the changes, or their absence is explicitly explained.
  • Documentation has been added or updated to reflect the changes, or their absence is explicitly explained.
  • A self-review has been conducted checking:
    • No unintended changes have been committed.
    • The changes in isolation seem reasonable.
    • Anything that may be odd or unintuitive is provided with a GitHub comment explaining it (but consider if this should not be a code comment or in the documentation instead).
  • All CI checks pass before pinging a reviewer, or provide an explanation if they do not.
  • The PR title matches the changelog entry's one-line description.

Related Issues

Closes #525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include Deserialized Assets in the submission endpoint

1 participant