Add uses_model and uses_dataset to Experiment model (#493)#722
Open
jolyboi wants to merge 2 commits intoaiondemand:developfrom
Open
Add uses_model and uses_dataset to Experiment model (#493)#722jolyboi wants to merge 2 commits intoaiondemand:developfrom
jolyboi wants to merge 2 commits intoaiondemand:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Change Type: Added
Change Category: Interface
Changelog Entry: Added
uses_modelanduses_datasetmany-to-many relationships to the Experiment model.These fields allow linking experiments to the ML models and datasets used during their execution, as specified in the AIoD metadata schema. The circular import between
experiment.pyandml_model.pyis handled using aTYPE_CHECKINGguard and deferred deserializer setup inml_model.py.Note:
exemplary_execution_settings(from #493) already exists in the codebase asexecution_settings— confirmed by the rename mapping inscripts/model_comparison/compare.pyline 39.How to Test
POST /experimentswithuses_modelanduses_datasetfields containing valid identifiers of existing ML models and datasetsGET /experiments/{identifier}and verify the relationships are returned correctlypython -m pytest src/tests/Checklist
Related Issues
Closes #493