feat: Make AI Builder API URL/Timeout configurable and secure Docker production build#721
Open
pratyush07-hub wants to merge 2 commits intoaiondemand:developfrom
Open
feat: Make AI Builder API URL/Timeout configurable and secure Docker production build#721pratyush07-hub wants to merge 2 commits intoaiondemand:developfrom
pratyush07-hub wants to merge 2 commits intoaiondemand:developfrom
Conversation
Author
|
Hi @PGijsbers @geetu040 , I've implemented the changes for #520. I've moved the API settings to the config system and updated the Docker orchestration to secure the production build. Ready for your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change(s)
src/config.default.toml).AIBuilderMLModelConnectorto dynamically fetch its endpoint and timeout settings from the global CONFIG object.docker-compose.yamlto ensure immutable deployments in production.docker-compose.dev.yaml, allowing for live-coding when USE_LOCAL_DEV=true is enabled.pyproject.tomlto allow assert statements in test files, resolving a pre-commit hook blockage.Change Type: Changed, Fixed, Security
Change Category: Internal, Other (Infrastructure)
Changelog Entry: Made AI Builder API URL and Timeout configurable and restricted source code mounting in production mode.
This PR refactors the AI Builder connector to utilize decentralized configuration, allowing Deployment-specific overrides for the API endpoint and response timeouts via
config.override.toml. It also aligns the Docker orchestration with production best practices by restricting source code mounts to development mode only.How to Test
pytest src/tests/connectors/aibuilder/test_aibuilder_mlmodel_connector.pyto verify that the connector correctly utilizes the configuration.Run
docker compose configand verify that theaibuilder-connectordoes not have a volume mount for /src.Run
./scripts/up.shaibuilder (with USE_LOCAL_DEV=true) and verify that the mount is present.Checklist
Related Issues
Closes #520