refactor: remove generic 'Enum' endpoints #605#708
Open
heisdinesh wants to merge 1 commit intoaiondemand:developfrom
Open
refactor: remove generic 'Enum' endpoints #605#708heisdinesh wants to merge 1 commit intoaiondemand:developfrom
heisdinesh wants to merge 1 commit intoaiondemand:developfrom
Conversation
- Exclude generic EnumRouter instances from router registration to remove endpoints like /keywords and /pysical_entities. - Retain TaxonomyRouter endpoints and internal NamedRelation normalization logic. - Rename test_license_router.py to test_enum_routers.py and add verification for 404 responses on removed endpoints.
Author
|
Hey @PGijsbers could you review this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change(s)
EnumRouterinstances from router registration to remove endpoints like/keywordsand/pysical_entities.TaxonomyRouterendpoints and internalNamedRelationnormalization logic.test_license_router.pytotest_enum_routers.pyand add verification for 404 responses on removed endpoints.Change Type: Removed
Change Category: Interface
Changelog Entry:
Removed generic enum endpoints (e.g.,
/keywords,/pysical_entities) that do not use Taxonomies.These endpoints were previously used to normalize string data, but this is now handled "under the hood" during resource creation/synchronization. Taxonomies and their corresponding endpoints remain available.
How to Test
GET /keywordsreturns404 Not FoundandGET /news_categories(a taxonomy) returns200 OK.Checklist
Related Issues
Closes #605