fix #166 (Got an error reading communication packets) for pool #987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
there is a problem for pool connections when the program exits even after using
pool.wait_closed()
it causes a ton of[Warning] Aborted connection 1 to db: 'database' user: 'user' host: '127.0.0.1' (Got an error reading communication packets)
warning in mariadb (maybe mysql too).the problem is in
aiomysql/connection.py
close
function:the close function just replaces
self._writer
content withNone
, it does not send any close packets.this causes the said warning.
just by using
await conn.ensure_closed()
instead ofconn.close()
inwait_closed()
function inPool
, the problem goes away.Are there changes in behavior for the user?
No.
Related issue number
Fixes #166
Checklist