Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated BrokerMetadata#nodeId type from int to int | str. #1051

Merged
merged 5 commits into from
Nov 16, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
FIXME.
jackgene committed Nov 3, 2024
commit 867069fd8c07515f7934aa0d73f8b204d0f88da8
5 changes: 3 additions & 2 deletions aiokafka/structs.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from __future__ import annotations
from collections.abc import Sequence
from dataclasses import dataclass
from typing import Generic, List, NamedTuple, Optional, Sequence, Tuple, TypeVar, Union
from typing import Generic, NamedTuple, Optional, Sequence, TypeVar

from aiokafka.errors import KafkaError

@@ -27,7 +28,7 @@ class TopicPartition(NamedTuple):
class BrokerMetadata(NamedTuple):
"""A Kafka broker metadata used by admin tools"""

nodeId: Union[int, str]
nodeId: int | str # FIXME consider updating implementation
"The Kafka broker id"

host: str