Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typing to aiokafka/coordinator/* #1006

Merged
merged 24 commits into from
Jun 29, 2024

Conversation

dimastbk
Copy link
Contributor

@dimastbk dimastbk commented May 6, 2024

Changes

Fixes #

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

aiokafka/coordinator/assignors/abstract.py Outdated Show resolved Hide resolved
aiokafka/coordinator/assignors/abstract.py Outdated Show resolved Hide resolved
aiokafka/coordinator/assignors/sticky/sticky_assignor.py Outdated Show resolved Hide resolved
aiokafka/coordinator/assignors/sticky/sticky_assignor.py Outdated Show resolved Hide resolved
@@ -37,8 +51,9 @@ def metadata(self, topics):
MemberMetadata struct
"""

@classmethod
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(offtopic) Why is it class method? It's strange to have a shared state among all clients

aiokafka/coordinator/assignors/sticky/sticky_assignor.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 96.06987% with 9 lines in your changes missing coverage. Please review.

Project coverage is 95.02%. Comparing base (14aa358) to head (5bf26b2).

Files Patch % Lines
...ka/coordinator/assignors/sticky/sticky_assignor.py 93.75% 3 Missing and 2 partials ⚠️
...iokafka/coordinator/assignors/sticky/sorted_set.py 85.00% 1 Missing and 2 partials ⚠️
aiokafka/coordinator/assignors/roundrobin.py 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1006      +/-   ##
==========================================
- Coverage   95.04%   95.02%   -0.03%     
==========================================
  Files         114      114              
  Lines       16906    16970      +64     
  Branches     2759     2771      +12     
==========================================
+ Hits        16068    16125      +57     
- Misses        493      497       +4     
- Partials      345      348       +3     
Flag Coverage Δ
cext 91.94% <96.06%> (+<0.01%) ⬆️
integration 94.67% <96.06%> (-0.03%) ⬇️
purepy 94.45% <96.06%> (-0.06%) ⬇️
unit 52.86% <96.06%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aiokafka/coordinator/assignors/sticky/sticky_assignor.py Outdated Show resolved Hide resolved
aiokafka/consumer/fetcher.py Outdated Show resolved Hide resolved
aiokafka/coordinator/assignors/sticky/sticky_assignor.py Outdated Show resolved Hide resolved
tests/coordinator/test_assignors.py Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@ods ods merged commit 4cba502 into aio-libs:master Jun 29, 2024
30 of 31 checks passed
@dimastbk dimastbk deleted the add-typing-to-coordinator branch June 30, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants