Skip to content

Remove aiohttp-mako #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 13, 2025
Merged

Remove aiohttp-mako #633

merged 7 commits into from
Feb 13, 2025

Conversation

Cycloctane
Copy link
Member

@Cycloctane Cycloctane commented Feb 12, 2025

What do these changes do?

  • Remove aiohttp-mako dependency.
  • Remove unused templates from demo.

Are there changes in behavior for the user?

Related issue number

Fixes #516

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@asvetlov
Copy link
Member

I guess you need to update the build matrix; remove py-3.8, add new pythons up to 3.13

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.18%. Comparing base (ccc01de) to head (b97c1e6).
Report is 91 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
+ Coverage   85.44%   86.18%   +0.74%     
==========================================
  Files          31       31              
  Lines        1834     1846      +12     
  Branches      229      230       +1     
==========================================
+ Hits         1567     1591      +24     
+ Misses        188      175      -13     
- Partials       79       80       +1     
Flag Coverage Δ
unit 86.07% <ø> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer
Copy link
Member

Looks good, thanks.

@Dreamsorcerer Dreamsorcerer merged commit 84ec09e into aio-libs:master Feb 13, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace aiohttp-mako
3 participants