Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve import time test #508

Merged
merged 15 commits into from
Feb 12, 2025
Merged

Improve import time test #508

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3d85a4e
Add Python 3.11/3.12
Dreamsorcerer Nov 19, 2023
149ff9b
Update versions.py
Dreamsorcerer Nov 19, 2023
e3d2ed1
Update test_imports.py
Dreamsorcerer Nov 19, 2023
f3a83e2
Update test_imports.py
Dreamsorcerer Nov 19, 2023
c953946
Update test_imports.py
Dreamsorcerer Nov 19, 2023
7335723
Update test_imports.py
Dreamsorcerer Nov 19, 2023
2358b6d
Merge branch 'master' into Dreamsorcerer-patch-1
Dreamsorcerer Feb 12, 2025
46f38e7
Update test_imports.py
Dreamsorcerer Feb 12, 2025
24fa148
Update test_imports.py
Dreamsorcerer Feb 12, 2025
eaccc38
Update test_imports.py
Dreamsorcerer Feb 12, 2025
9bb1c0d
Update test_imports.py
Dreamsorcerer Feb 12, 2025
a1e85ee
Update test_imports.py
Dreamsorcerer Feb 12, 2025
203830e
Update test_imports.py
Dreamsorcerer Feb 12, 2025
5a9f4f6
Update tests/test_imports.py
Dreamsorcerer Feb 12, 2025
ab7fc14
Update test_imports.py
Dreamsorcerer Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions tests/test_imports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@


@pytest.mark.skipif(
not sys.platform.startswith("linux") or platform.python_implementation() == "PyPy",
not sys.platform.startswith("linux")
or platform.python_implementation() == "PyPy"
or sys.version_info[:2] == (3, 12),
reason="Unreliable",
)
def test_import_time(pytester: pytest.Pytester) -> None:
Expand All @@ -14,9 +16,14 @@ def test_import_time(pytester: pytest.Pytester) -> None:
from time to time, but this should provide an early warning if something is
added that significantly increases import time.
"""
r = pytester.run(
sys.executable, "-We", "-c", "import aiohttp_debugtoolbar", timeout=0.95
)
best_time_ms = 1000
cmd = "import timeit; print(int(timeit.timeit('import aiohttp_debugtoolbar', number=1)*1000))"
for _ in range(3):
r = pytester.run(sys.executable, "-We", "-c", cmd)

assert not r.stdout.str()
assert not r.stderr.str()
assert not r.stderr.str()
runtime_ms = int(r.stdout.str())
if runtime_ms < best_time_ms:
best_time_ms = runtime_ms

assert best_time_ms < 350
Loading