docs(rfc): clarify read-existing adapter contract by aimasteracc · Pull Request #1255 · aimasteracc/tree-sitter-analyzer

aimasteracc · 2026-08-13T08:55:52Z

Summary

clarify RFC-0022 P0.4 before implementation because its capture trigger, P0.2 temp plumbing, process-local registries, and CLI parity requirements were mutually ambiguous
make access_mode="read_existing" the fail-closed zero-write capture contract, with capture_diff_snapshot forbidden and all required producer outputs explicit
freeze primitive-owned access evidence/provenance, including NO_CONFIG, and require native write-attempt authority on every certified platform
keep process-local capability controls off unusable public CLI flags through a narrow documented parity exception; preserve the eight-facade/ninth-facade gate

Design consequences

legacy explicit P0.2 capture may retain its existing external temp plumbing
P0.4 needs a separate zero-filesystem-write backend that passes the full P0.2 golden corpus; otherwise Phase A stays blocked
an OS without a descendant-aware native write-attempt authority returns a stable unsupported result and is not certified
no production implementation or ninth facade is included in this PR

Verification

uv run python -m tree_sitter_analyzer --change-impact --format json → docs-only, pytest_required=false, verification=git diff --check
git diff --check
uv run pre-commit run --files rfcs/0022-task-outcome-apis.md
independent RFC zero-gate: B=0, P1=0, P2=0, P3=0

Follow-up

After this clarification lands, rebuild the P0.4 feature worktree from the new develop head and implement the seven read-existing adapters RED-first. Phase A/P0.5 and any ninth facade remain out of scope.

aimasteracc · 2026-08-13T08:56:00Z

@codex review

github-actions · 2026-08-13T08:56:50Z

🔍 Dogfood PR Check

Layer	Status
Change Impact	✅ passed
Claim Invariant Suite	✅ passed

Change impact: change_impact changed=2 risk=low pytest_required=True
Verification: uv run pytest tests/unit/mcp/test_change_impact_tool.py tests/unit/mcp/test_change_impact_tool_execute_and_mapping.py tests/unit/mcp/test_change_impact_tool_git_and_verification.py tests/unit/test_change_impact_analysis.py tests/unit/test_change_impact_cached_graph.py tests/unit/test_change_impact_git.py tests/unit/test_change_impact_response.py tests/unit/test_temporal_change_impact.py -q
Claim summary: ====================== 17 passed, 12 deselected in 1.45s =======================

Claim invariant test output (last 30 lines)

============================= test session starts ==============================
collected 29 items / 12 deselected / 17 selected

tests/benchmarks/claims/test_bm25_ranking_invariant.py ....              [ 23%]
tests/benchmarks/claims/test_reactive_push_e2e.py .......                [ 64%]
tests/benchmarks/claims/test_safety_layers_smoke.py ......               [100%]

- generated xml file: /home/runner/work/tree-sitter-analyzer/tree-sitter-analyzer/dogfood-claims.xml -
====================== 17 passed, 12 deselected in 1.45s =======================

What these tests guard:

390× cross-language mis-wire claim
BM25 ranked search with relevance_score
5 safety layers (safe/guard/constraints/impact/verdicts)
Reactive push subscribe/unsubscribe (RFC-0001)
Index build speed regression

Full results: workflow run

Dogfood PR Check — docs/superpowers/specs/2026-07-08-svcd-dogfood-system-design.md

chatgpt-codex-connector · 2026-08-13T08:58:43Z

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 58d5ab943d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…existing-contract

aimasteracc · 2026-08-13T09:33:53Z

@codex review

aimasteracc · 2026-08-13T09:34:15Z

Prerequisite PR #1256 merged as c995fdc02105a5af3892f77ae41a5283e44db74f to restore full history in docs-only CI. This branch now merges the new develop base. The effective RFC diff is byte-for-byte unchanged from the independently reviewed tree (git diff --binary origin/develop..HEAD SHA-256 985fb27a9a25644a9bcebbaa9bc60f11dd10a7d985a0b8e06693def824044eb1); no production implementation was added. Fresh CI and Codex were requested for current head e1ca1d0c9024ceb1a847939566fc268605946c0a.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e1ca1d0c90

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-13T09:49:27Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6223bbe6eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-13T09:59:30Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b6fe4cf64

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-13T10:16:29Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cde10cf340

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codecov · 2026-08-13T10:28:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

aimasteracc · 2026-08-13T10:29:30Z

@codex review

chatgpt-codex-connector · 2026-08-13T10:33:54Z

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: bd00b318dd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

docs(rfc): clarify read-existing adapter contract

58d5ab9

aimasteracc mentioned this pull request Aug 13, 2026

fix(ci): fetch history for docs contracts #1256

Merged

Merge remote-tracking branch 'origin/develop' into docs/no1-p04-read-…

e1ca1d0

…existing-contract

chatgpt-codex-connector Bot reviewed Aug 13, 2026

View reviewed changes

Comment thread rfcs/0022-task-outcome-apis.md Outdated

Comment thread rfcs/0022-task-outcome-apis.md Outdated

Comment thread rfcs/0022-task-outcome-apis.md Outdated

Comment thread rfcs/0022-task-outcome-apis.md Outdated

Comment thread rfcs/0022-task-outcome-apis.md Outdated

docs(rfc): close read-existing review gaps

6223bbe

chatgpt-codex-connector Bot reviewed Aug 13, 2026

View reviewed changes

Comment thread rfcs/0022-task-outcome-apis.md Outdated

Comment thread AGENTS.md Outdated

Comment thread rfcs/0022-task-outcome-apis.md Outdated

docs(rfc): bind exact process-local authorities

9b6fe4c

chatgpt-codex-connector Bot reviewed Aug 13, 2026

View reviewed changes

Comment thread rfcs/0022-task-outcome-apis.md Outdated

test(rfc): lock process-local parity boundary

cde10cf

chatgpt-codex-connector Bot reviewed Aug 13, 2026

View reviewed changes

Comment thread tests/contracts/test_mcp_cli_parity_contract.py Outdated

Comment thread rfcs/0022-task-outcome-apis.md Outdated

docs(rfc): make lifecycle cleanup exact

bd00b31

aimasteracc merged commit deb8498 into develop Aug 13, 2026
33 checks passed

aimasteracc deleted the docs/no1-p04-read-existing-contract branch August 13, 2026 10:46

Uh oh!

Conversation

aimasteracc commented Aug 13, 2026

Summary

Design consequences

Verification

Follow-up

Uh oh!

aimasteracc commented Aug 13, 2026

Uh oh!

github-actions Bot commented Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 Dogfood PR Check

Uh oh!

chatgpt-codex-connector Bot commented Aug 13, 2026

Uh oh!

aimasteracc commented Aug 13, 2026

Uh oh!

aimasteracc commented Aug 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aimasteracc commented Aug 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aimasteracc commented Aug 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

aimasteracc commented Aug 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Aug 13, 2026

Codecov Report

Uh oh!

aimasteracc commented Aug 13, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Aug 13, 2026 •

edited

Loading