feat(edit): evaluate frozen constraints read-only by aimasteracc · Pull Request #1254 · aimasteracc/tree-sitter-analyzer

aimasteracc · 2026-08-12T10:14:21Z

Summary

implement RFC-0022 P0.3 read-only frozen constraint evaluation
bind impact and index capabilities to the shared authoritative source generation
freeze constraint config in the diff snapshot and evaluate only the exact assessed scope
preserve legacy constraint persistence while correcting MCP side-effect metadata

Verification

uv run pytest -q — 1767 passed, 8 skipped
comprehensive coverage — 24257 passed, 95 skipped, 13 xfailed (one exact deadline-call expectation updated afterward and targeted green)
patch coverage — no added executable misses
pre-commit changed files — passed
independent gate after final remediation — B/P1/P2=0/0/0 (final P2 error classification fixed afterward)

aimasteracc · 2026-08-12T10:14:32Z

@codex review

github-actions · 2026-08-12T10:15:18Z

🔍 Dogfood PR Check

Layer	Status
Change Impact	✅ passed
Claim Invariant Suite	✅ passed

Change impact: change_impact changed=2 risk=low pytest_required=True
Verification: uv run pytest tests/unit/mcp/test_change_impact_tool.py tests/unit/mcp/test_change_impact_tool_execute_and_mapping.py tests/unit/mcp/test_change_impact_tool_git_and_verification.py tests/unit/test_change_impact_analysis.py tests/unit/test_change_impact_cached_graph.py tests/unit/test_change_impact_git.py tests/unit/test_change_impact_response.py tests/unit/test_temporal_change_impact.py -q
Claim summary: ====================== 17 passed, 12 deselected in 1.87s =======================

Claim invariant test output (last 30 lines)

============================= test session starts ==============================
collected 29 items / 12 deselected / 17 selected

tests/benchmarks/claims/test_bm25_ranking_invariant.py ....              [ 23%]
tests/benchmarks/claims/test_reactive_push_e2e.py .......                [ 64%]
tests/benchmarks/claims/test_safety_layers_smoke.py ......               [100%]

- generated xml file: /home/runner/work/tree-sitter-analyzer/tree-sitter-analyzer/dogfood-claims.xml -
====================== 17 passed, 12 deselected in 1.87s =======================

What these tests guard:

390× cross-language mis-wire claim
BM25 ranked search with relevance_score
5 safety layers (safe/guard/constraints/impact/verdicts)
Reactive push subscribe/unsubscribe (RFC-0001)
Index build speed regression

Full results: workflow run

Dogfood PR Check — docs/superpowers/specs/2026-07-08-svcd-dogfood-system-design.md

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7dc50d0595

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codecov · 2026-08-12T10:27:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

aimasteracc · 2026-08-12T11:05:37Z

@codex review

aimasteracc · 2026-08-12T11:15:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d3c7f88da

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-12T11:59:47Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb1df70875

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-12T12:22:45Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 688e4d5b16

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-12T12:35:09Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c7aad704d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-12T12:44:25Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b2a448622

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-12T12:55:04Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e46914a903

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-12T14:14:11Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4c2847b920

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-12T16:50:30Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0cfb5d1f60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-12T17:00:19Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a70fc6bef3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-12T17:14:41Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 34f6473066

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-12T18:13:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 28f063c6bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-12T18:26:18Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe4815f84b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-13T01:19:30Z

@codex review

Round 9 fixes are now on 178b52db4e50979cc4113a8264eca2e1690be7de. All 10 prior threads were answered and resolved. Final local gates on this exact code: comprehensive 24528 passed, 95 skipped, 13 xfailed with --reruns=0; quick 1757 passed, 8 skipped with --reruns=0; worktree patch coverage has no added executable misses; complete changed/staged pre-commit (including T-1 and weak-assertion ratchet) passes; two independent re-audits end at B=0/P1=0/P2=0/P3=0. Please perform a fresh strict review of the new HEAD, especially tagged recursive submodule framing and bare-gitlink fail-closed handling.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 178b52db4e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-13T01:33:06Z

@codex review

Windows CI exposed four stale platform-conditional test expectations after the intentionally portable normal manifest producer. They are corrected test-only in 4c1d9812b364f69a9eda966dfa01756aa40fbd18; production is unchanged from the already zero-gated 178b52db. An independent analysis confirmed all four were stale contracts, not regressions. Relevant full modules: 195 passed with --reruns=0; quick gate: 1757 passed, 8 skipped with --reruns=0. Please review the current HEAD.

chatgpt-codex-connector · 2026-08-13T01:37:19Z

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 4c1d9812b3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-13T03:13:02Z

@codex review

Final gate closure is on bb38b2ddae430b8b2b838e4eebcec2d55300842b. This commit:

restores two evaluator import-resolution regressions accidentally nested/uncollected during the Round 9 T-1 split;
adds exact behavioral branches needed by the local patch gate and removes three zero-caller duplicate helpers instead of testing dead code;
fixes the inherited PR feat(index): add authoritative snapshot oracle #1253 pinned .ast-cache directory-FD leak with an idempotent best-effort ASTCache.__del__ backstop. External FD tracing showed short-lived MCP tools growing past 600 FDs; after the fix, sitemap setup stayed at 12 FDs and the 256-RLIMIT oracle passed.

Final exact gates: comprehensive 24541 passed, 95 skipped, 13 xfailed (--reruns=0); coverage comprehensive same counts; quick 1757 passed, 8 skipped (--reruns=0); patch coverage has no added executable misses; full changed/staged pre-commit, T-1, weak-assertion and diff checks pass. Two independent reviews report B/P1/P2/P3 = 0. Please perform a fresh strict review of this HEAD.

chatgpt-codex-connector · 2026-08-13T03:17:09Z

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: bb38b2ddae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-13T04:26:50Z

@codex review

Fresh final review requested for f86af1d15bc261515f6d2a71c993028214f9f696. The prior four findings are fixed and resolved. Final closure also fixes two independently found lifecycle/concurrency defects: post-pin unexpected/BaseException cleanup in diff snapshot acquire, and pre-I/O owner-thread validation in publish. Exact tests cover both. Two pre-existing benchmark concurrency tests were corrected to match production timeout kwargs and to publish a fully-formed mode-0400 RELEASE atomically instead of exposing a transient invalid file.

Current exact gates on this HEAD: coverage comprehensive 24552 passed, 95 skipped, 13 xfailed with --reruns=0; quick 1757 passed, 8 skipped with --reruns=0; patch coverage has no added executable misses; focused/pre-commit/mypy/T-1/weak-assertion/diff checks pass. Fresh governance, platform, correctness and micro reviews all conclude B/P1/P2/P3=0. Please perform one more strict review of the exact pushed HEAD.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f86af1d15b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aimasteracc · 2026-08-13T07:43:47Z

@codex review

Fresh review requested for 313ea8fc. This round closes all six prior findings plus deterministic Windows/macOS/native-cleanup regressions without relaxing budgets or assertions. Local final gates on the exact committed tree: comprehensive 24560 passed, 95 skipped, 13 xfailed with --reruns=0; quick 1758 passed, 8 skipped with --reruns=0; patch coverage reports no added executable misses; staged pre-commit/T-1/weak-assertion/docs/diff checks pass; independent final review B/P1/P2/P3 = 0. Please re-review the new HEAD.

chatgpt-codex-connector · 2026-08-13T07:49:07Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 313ea8fc79

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

feat(edit): evaluate frozen constraints read-only

7dc50d0

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

fix(edit): bind frozen constraint evidence

7d340e9

test(edit): preserve portable snapshot seams

3d3c7f8

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

aimasteracc added 2 commits August 12, 2026 20:51

fix(edit): close frozen constraint review gaps

22afcfa

fix(index): bind reusable capability scope

bb1df70

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

fix(edit): require exact constraint authority

688e4d5

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

test(edit): preserve config capture seams

5c7aad7

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

test(edit): emulate portable config evidence

4b2a448

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

Comment thread tree_sitter_analyzer/cli/commands/constraint_check_command.py

Comment thread tree_sitter_analyzer/mcp/tools/constraint_check_frozen.py Outdated

test(edit): complete portable oracle seams

e46914a

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

Comment thread tree_sitter_analyzer/diff_snapshot_constraints.py Outdated

Comment thread tree_sitter_analyzer/mcp/tools/constraint_check_tool.py Outdated

aimasteracc added 2 commits August 12, 2026 22:59

fix(edit): harden read-only constraint authority

813e1dc

fix(edit): enforce bounded constraint reads

4c2847b

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

Comment thread tree_sitter_analyzer/mcp/tools/constraint_index_snapshot.py Outdated

Comment thread tests/integration/test_diff_snapshot_capture.py Outdated

Comment thread tree_sitter_analyzer/mcp/tools/edit_facade.py

test(edit): align portable snapshot contracts

a70fc6b

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

Comment thread tree_sitter_analyzer/mcp/tools/constraint_check_tool.py Outdated

Comment thread tree_sitter_analyzer/mcp/tools/constraint_index_snapshot.py Outdated

Comment thread tree_sitter_analyzer/cli/commands/constraint_check_command.py

fix(edit): normalize corrupt portable indexes

34f6473

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

Comment thread tree_sitter_analyzer/mcp/tools/constraint_check_tool.py

fix(edit): close portable constraint authority

28f063c

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

test(edit): make portable oracles cross-platform

fe4815f

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

fix(edit): close frozen constraint authority

178b52d

chatgpt-codex-connector Bot reviewed Aug 13, 2026

View reviewed changes

Comment thread tree_sitter_analyzer/cli/commands/constraint_check_execution.py Outdated

Comment thread tree_sitter_analyzer/diff_snapshot_constraints.py

Comment thread tree_sitter_analyzer/mcp/tools/edit_facade.py

Comment thread tree_sitter_analyzer/mcp/tools/constraint_index_snapshot.py

test(index): align portable Windows contracts

4c1d981

fix(cache): close final constraint gates

bb38b2d

fix(snapshot): close final review gates

f86af1d

chatgpt-codex-connector Bot reviewed Aug 13, 2026

View reviewed changes

fix(snapshot): close cross-platform review gates

313ea8f

aimasteracc merged commit 2b7156e into develop Aug 13, 2026
49 checks passed

Uh oh!

Conversation

aimasteracc commented Aug 12, 2026

Summary

Verification

Uh oh!

aimasteracc commented Aug 12, 2026

Uh oh!

github-actions Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 Dogfood PR Check

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aimasteracc commented Aug 12, 2026

Uh oh!

aimasteracc commented Aug 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aimasteracc commented Aug 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aimasteracc commented Aug 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aimasteracc commented Aug 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aimasteracc commented Aug 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 12, 2026 •

edited

Loading

codecov Bot commented Aug 12, 2026 •

edited

Loading