-
Notifications
You must be signed in to change notification settings - Fork 1
chore(pm): v306 — PR #915 merged, v305 archive added, escalation ×164 #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this commit,
git log --format='%(trailers:key=Signed-off-by)' 41ac4a8^..41ac4a8returns noSigned-off-bytrailer, but the repo hard rules require DCO on every commit. As-is, this chore will fail the DCO gate or block merge until the commit is recreated/amended withgit commit -s.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rejected — false positive (same pattern as PR #915 Codex P1).
The referenced commit
41ac4a8is not present in this PR. PR #917 has exactly two commits:267fa4dc—chore(pm): v306 — ...— carriesSigned-off-by: aimasteracc✅3864cca7—chore(pm): fix PR reference #916→#917...— carriesSigned-off-by: aimasteracc✅Both commits have valid DCO trailers. The DCO CI job (
82310180252) reports SUCCESS. The SHA41ac4a8likely refers to an intermediate or rebased commit that no longer exists on this branch.This is structurally identical to the false-positive flagged on PR #915 (intermediate commit SHA, DCO CI ✅). Proceeding with merge.
Generated by Claude Code