-
Notifications
You must be signed in to change notification settings - Fork 1
ci(release): graceful npm publish — token absent + E404 scope-not-found + PM dispatch v41 #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the
@aimasteraccscope is absent, thisreturn 0makes the wholepublish-npmjob succeed even though none of the npm packages were published; becausefinalizehasneeds: [validate, publish-crates, publish-npm, publish-pypi, build-cli-binaries], a manual release can then merge tomain, tag, and create the GitHub Release while the npm install path promised by RFC-0110 is unavailable. In that first-release/scope-missing context, this turns a registry publication failure into a green release gate rather than a retryable configuration failure.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spinning off as Issue #534 (
fix(release): re-enable hard E404 failure in publish_one() once @aimasteracc npm scope is registered).Justification for graceful degradation at v0.2.0: The
@aimasteraccscope has never been registered on npmjs.com — this is a one-time founder infrastructure action, not a code defect. Blocking the v0.2.0 release ceremony on npm infrastructure readiness would prevent shipping the binary release (the primary deliverable for all users without the npm channel), while the npm channel is explicitly documented as inactive in the PR body ("Founder action still required") and in the CHANGELOG (npm marked "🔜 v0.2"). The graceful degradation is therefore intentional, documented, and temporary.Why not just mark publish-npm as SKIPPED?
continue-on-errorwould mark the job SKIPPED only on total failure; theE404lands inside a shell function that must distinguish "already published" (idempotent OK) from "scope missing" (configuration gap) from "real publish error" (hard stop). The current approach handles all three without external workflow restructuring.Issue #534 tracks the tightening after scope registration. Marking this finding as addressed (spin-off).
Generated by Claude Code