Skip to content

Update holiday calendars: add recent statutory changes and extend known periods - #24

Merged
adulau merged 1 commit into
mainfrom
codex/update-holiday-periods-in-tempolocus
Aug 29, 2026
Merged

adulau merged 1 commit into
mainfrom
codex/update-holiday-periods-in-tempolocus

Conversation

@adulau

@adulau adulau commented Aug 29, 2026

Copy link
Copy Markdown
Member

Motivation

  • Bring the built-in holiday reference data up to date with recent statutory changes and published date windows so yearly inference uses current reference signals.
  • Cover newly legislated or restored public holidays and extend explicit lunar/Matariki tables where official published dates are available.

Description

  • Update tempolocus/core.py to add Ireland's Saint Brigid's Day (date-aware from 2023), Italy's Saint Francis of Assisi Day (effective 2026), Poland's Christmas Eve (effective 2025), and make Ukraine holiday entries date-aware to reflect recent changes.
  • Extend explicit lookup tables for Chinese New Year and Korean Chuseok through 2035 and add published New Zealand Matariki dates through 2052.
  • Add new/updated unit tests in tests/test_tempolocus.py that assert the presence of these updates and extended lunar/Matariki reference coverage.
  • Update README.md to document the new coverage, limitations for lunar/islamic dates, and guidance that calendars are reference signals rather than payroll calendars.

Testing

  • Ran python -m pytest -q and all tests passed (34 passed).
  • Ran python -m compileall -q tempolocus tests and the code compiled without errors.
  • Ran repository checks (git diff --check / status) and added the new tests and documentation; the test suite and static checks succeeded.

Codex Task

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-29T10:16:14.668289Z b6c80c0 PR opened
🔒 Security Review ✅ Completed 2026-08-29T10:16:21.408895Z b6c80c0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@adulau
adulau merged commit e6d92be into main Aug 29, 2026
8 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b6c80c014c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tempolocus/core.py
_fixed(year, 10, 14, "Defenders Day"),
_fixed(year, 12, 25, "Christmas Day"),
]
if year < 2023:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve Ukraine's pre-repeal 2023 holidays

For Ukrainian yearly input from 2023, this year-only cutoff rewrites holidays that had already occurred before the relevant laws took effect: January 7 and May 9 were still statutory holidays on those dates, while the replacement May 8 holiday was enacted only afterward. As a result, _candidate_holidays(2023) now omits two actual 2023 reference signals and adds one retroactively, which can distort Ukraine's score; 2023 needs a boundary-specific calendar rather than being handled entirely by the post-change branch.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant