Repository navigation
Update holiday calendars: add recent statutory changes and extend known periods - #24
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6c80c014c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _fixed(year, 10, 14, "Defenders Day"), | ||
| _fixed(year, 12, 25, "Christmas Day"), | ||
| ] | ||
| if year < 2023: |
There was a problem hiding this comment.
Preserve Ukraine's pre-repeal 2023 holidays
For Ukrainian yearly input from 2023, this year-only cutoff rewrites holidays that had already occurred before the relevant laws took effect: January 7 and May 9 were still statutory holidays on those dates, while the replacement May 8 holiday was enacted only afterward. As a result, _candidate_holidays(2023) now omits two actual 2023 reference signals and adds one retroactively, which can distort Ukraine's score; 2023 needs a boundary-specific calendar rather than being handled entirely by the post-change branch.
Useful? React with 👍 / 👎.
Motivation
Description
tempolocus/core.pyto add Ireland's Saint Brigid's Day (date-aware from 2023), Italy's Saint Francis of Assisi Day (effective 2026), Poland's Christmas Eve (effective 2025), and make Ukraine holiday entries date-aware to reflect recent changes.tests/test_tempolocus.pythat assert the presence of these updates and extended lunar/Matariki reference coverage.README.mdto document the new coverage, limitations for lunar/islamic dates, and guidance that calendars are reference signals rather than payroll calendars.Testing
python -m pytest -qand all tests passed (34 passed).python -m compileall -q tempolocus testsand the code compiled without errors.git diff --check/ status) and added the new tests and documentation; the test suite and static checks succeeded.Codex Task